Make sysctl calls on FreeBSD

[sambler]

The OS module get_unique_id and get_processor_name rely on linux files which don't exist on a standard FreeBSD install, make sysctl calls to get the required data.

I expect OpenBSD and NetBSD would require similar changes.

[AThousandShips]

You didn't update your branch, it is still about 18 months out of date, please update your branch with git rebase -i master after updating your master branch to the latest version

[akien-mga]

There are still style issues that would be fixed by clang-format (or checking surrounding code and using the same style).

And the commits are still not linked to your GH account.

[sambler]

@akien-mga hi, when I look at the commit history it says I authored and committed the changes, so I'm not sure how its not linked to my account, or what I would need to change.

[AThousandShips]

See: Why are my commits linked to the wrong user? for more info.

[sambler]

Seems there was a capital letter in my github email that makes it different to the commit info.

[akien-mga]

Didn't test, but assuming it works, the changes seem fine.

Could you squash the commits? See PR workflow for instructions.

While doing so, you would also get a change to update your Git email to make it match your GitHub account's (with git commit --amend --reset-author after changing your local or global Git email).

[akien-mga]

You added unexpected changes, you probably rebased on your old local master branch again instead of upstream.

You can go back with git reset --hard e42a8fd8ab49e9735be77525d22882b75d3d802d and try again with:

git remote add upstream https://github.com/godotengine/godot
git fetch upstream
git checkout sysctl_adjust
git rebase -i upstream/master

And for good measure, you could also do:

git checkout master
git reset --hard upstream/master

to stop going back to 18 months old code :)

[sambler]

I think it looks right this time

[akien-mga]

Yes, looks great!

[akien-mga]

Looks good! Could you squash the commits?

[sambler]

@akien-mga should be good to go now. Note that I also added the String::utf8 change which I didn't push earlier.

[akien-mga]

Thanks! And congrats for your first merged Godot contribution 🎉

[akien-mga]

Cherry-picked for 4.2.2.