Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Animation] Expose SkeletonProfile.set/is_required #89970

Merged
merged 1 commit into from
Apr 5, 2024
Merged

[Animation] Expose SkeletonProfile.set/is_required #89970

merged 1 commit into from
Apr 5, 2024

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips added this to the 4.x milestone Mar 28, 2024
@AThousandShips AThousandShips requested a review from a team as a code owner March 28, 2024 08:41
AThousandShips
AThousandShips commented Mar 28, 2024
View reviewed changes
scene/resources/skeleton_profile.h Outdated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went ahead and cleaned up some arguments while I was at it here

@AThousandShips AThousandShips changed the title [Animation] Expose SkeletonProfile.set/is_require [Animation] Expose SkeletonProfile.set/is_required Mar 28, 2024
@AThousandShips AThousandShips force-pushed the require_expose branch 2 times, most recently from 5c25743 to e850ee6 Compare March 28, 2024 12:00
TokageItLab
TokageItLab approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@TokageItLab TokageItLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Apr 5, 2024
@akien-mga akien-mga merged commit b7e0b0e into godotengine:master Apr 5, 2024
16 checks passed
@AThousandShips AThousandShips deleted the require_expose branch April 5, 2024 10:27
@akien-mga
Copy link
Member

Thanks!

@AThousandShips
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga left review comments

@TokageItLab TokageItLab TokageItLab approved these changes

Assignees
No one assigned
Labels
enhancement topic:animation
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

SkeletonProfile's is_require(), and set_require() aren't exposed
3 participants
@AThousandShips @akien-mga @TokageItLab