Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return ERR_UNAVAILABLE if native dialog is not supported #89902

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

timothyqiu
Copy link
Member

Otherwise, there's no way to tell whether the dialog actually pops up (except for hard-coding supported platforms).

@timothyqiu timothyqiu added this to the 4.3 milestone Mar 26, 2024
@timothyqiu timothyqiu requested a review from a team as a code owner March 26, 2024 10:53
@akien-mga akien-mga requested a review from bruvzg March 26, 2024 10:57
Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks OK.

But it's probably something that should be also checkable via has_feature. There's already FEATURE_NATIVE_DIALOG for the native file dialogs, it probably should be split into multiple options to allow checking for each type of dialog.

@timothyqiu
Copy link
Member Author

Because these functions return Error, they could technically still fail to show the dialog for other reasons on display servers that do have an implementation. In practice, I find it reasonable to handle all "failure of opening a native dialog" situation the same way :P

@akien-mga akien-mga merged commit 7d151c8 into godotengine:master Mar 26, 2024
16 checks passed
@timothyqiu timothyqiu deleted the not-available branch March 26, 2024 12:50
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants