-
-
Notifications
You must be signed in to change notification settings - Fork 21.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong return type mention in AStarGrid2D
docs
#89862
Conversation
Please amend your commit message to be more detailed, the new name of the PR would be good |
I mean the message of your commit, not the text of the PR, you need to do:
And change the message |
You need to push with
|
e19aff7
to
a8e6160
Compare
Sorry that message isn't very clear, please change it to the title of this PR, or something else short :) |
@AThousandShips thank you for your assistance 👍 |
a8e6160
to
8e18d2c
Compare
It should be:
The title needs to be at the top :) Sorry for the finicky thing to solve |
8e18d2c
to
ec797ba
Compare
ok... maybe this time -.- |
There! |
AStarGrid2D
AStarGrid2D
docs
Just my two cents: It's unnecessary to explicitly mention the type here. The function signature already contains the return type 😛
|
ec797ba
to
b7beea5
Compare
Pushed an update with that change for all three classes. |
Thanks! |
Cherry-picked for 4.2.2. |
Cherry-picked for 4.1.4. |
The docs for AStarGrid2D say that they would return a PackedVector3Array while inside a thread but the typing for that function is PackedVector2Array. This fixes the Typo