Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reference to InputEventJoypadButton in _shortcut_input doc #89838

Merged

Conversation

Chronos-W
Copy link
Contributor

@Chronos-W Chronos-W commented Mar 24, 2024

According to the fix in #66750, InputEventJoypadButton can now be used in _shortcut_input, but it looks like this info hasn't been added to the docs https://docs.godotengine.org/en/latest/classes/class_node.html#class-node-private-method-shortcut-input.

After this change, InputEventJoypadButton will be mentioned alongside the other InputEvents in this method's doc.

Note that information about this has already been added to https://docs.godotengine.org/en/latest/tutorials/inputs/inputevent.html#how-does-it-work.

@Chronos-W Chronos-W requested a review from a team as a code owner March 24, 2024 04:40
@Chaosus Chaosus added this to the 4.3 milestone Mar 24, 2024
@AThousandShips AThousandShips added cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release and removed topic:input labels Mar 24, 2024
@akien-mga akien-mga changed the title Add reference to InputEventJoypadButton in _shortcut_input doc Add reference to InputEventJoypadButton in _shortcut_input doc Mar 25, 2024
@akien-mga
Copy link
Member

For the record, your commit seems not to be linked to your GitHub account. See: Why are my commits linked to the wrong user? for more info.

In particular, you authored this commit as <[email protected]> which I assume isn't an email you actually own ;)
If you want to use an anonymous email, see https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/setting-your-commit-email-address

You can then update this commit with git commit --amend --reset-author after updating your configured Git author email.

@Chronos-W Chronos-W force-pushed the update-shortcut-input-method-doc branch from 359a5c0 to 9a439b2 Compare March 26, 2024 01:44
@Chronos-W
Copy link
Contributor Author

Think it's good now. Thanks for catching that.

@akien-mga akien-mga merged commit cff7de0 into godotengine:master Mar 26, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@Chronos-W Chronos-W deleted the update-shortcut-input-method-doc branch March 27, 2024 05:21
@akien-mga
Copy link
Member

Cherry-picked for 4.2.2.

@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Apr 8, 2024
@akien-mga
Copy link
Member

Cherry-picked for 4.1.4.

@akien-mga akien-mga removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants