Prefer family name in fonts' names table #89817
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
family_name
is used as a font's name. This field is an ASCII string, butFreeType converts non-ASCII characters into question marks ("?") in this process, resulting in unreadable names for some fonts.
This PR prioritizes reading SFNT names (the name table of TrueType and OpenType fonts) to avoid possible question marks. English (US) is still preferred, so it's mostly compatible.
Among possible encodings, UTF-16 is the most common one that Godot's
String
supports. But it's always in big endian, so I added an extra parameter toString::parse_utf16()
to specify the endianness to use when no BOM is present.