Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS Export] Check directory content before deleting old export leftovers. #89790

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Mar 22, 2024

Fixes #89715

Makes iOS export a bit safer. Instead of deleting previous export folders (project_name and project_name.xcodeproj, was partially broken) without any checks, exporter delete them only if most of the files in the folder match expected files for the previous export (or export option to delete unconditionally is enabled).

@bruvzg bruvzg added this to the 4.3 milestone Mar 22, 2024
@bruvzg bruvzg marked this pull request as ready for review April 22, 2024 07:06
@bruvzg bruvzg requested a review from a team as a code owner April 22, 2024 07:06
@akien-mga akien-mga merged commit 1f303e0 into godotengine:master Apr 29, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When exporting an iOS Project will delete source code
2 participants