Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix documentation for receiving light from light probes #89699

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Fix documentation for receiving light from light probes #89699

merged 1 commit into from
Apr 4, 2024

Conversation

Enhex
Copy link
Contributor

@Enhex Enhex commented Mar 20, 2024

For geometry to receive light from lightmap's light probes its global illumination mode needs to be set to Dynamic.

@Enhex Enhex requested a review from a team as a code owner March 20, 2024 00:27
@Mickeon Mickeon added this to the 4.3 milestone Mar 20, 2024
Mickeon
Mickeon approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me but I am not sure if it's correct or some form of misunderstanding.

@Enhex
Copy link
Contributor Author

Enhex commented Mar 20, 2024

here's a Godot project to test it out, try changing the GI mode on the sphere and move it around:
lightmap_probe.zip

@akien-mga akien-mga requested a review from Calinou March 23, 2024 23:28
Calinou
Calinou approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is indeed correct. I likely added the description to the wrong constant at the time.

@Calinou Calinou added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Apr 4, 2024
@akien-mga akien-mga merged commit fb32399 into godotengine:master Apr 4, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 4.2.2.

@akien-mga akien-mga added cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release and removed cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Apr 8, 2024
@akien-mga
Copy link
Member

Cherry-picked for 4.1.4.

@akien-mga akien-mga removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou approved these changes

@Mickeon Mickeon Mickeon approved these changes

Assignees
No one assigned
Labels
documentation enhancement
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@Enhex @akien-mga @Calinou @Mickeon