[StatusIndicator] Switch API to use Texture2D instead of Image, improve handling on macOS, add method to set native popup menu directly. #89588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Riteo
reviewed
Mar 17, 2024
bruvzg
force-pushed
the
status_ind_menu_direct
branch
from
9be3957
to
457df33
Compare
Mickeon
reviewed
Mar 20, 2024
doc/classes/DisplayServer.xml
Outdated
Comment on lines
1192
to
1194
| [b]Note:[/b] On macOS, menu is activated by any mouse button, activation callback is not triggered. | ||
| [b]Note:[/b] On Windows, menu is activated by right mouse button, selecting icon and pressing Shift+F10 or the applications key, activation callback for the other mouse buttons is still triggered. | ||
| [b]Note:[/b] Native popup is supported only if [NativeMenu] supports [constant NativeMenu.FEATURE_POPUP_MENU] feature. |
There was a problem hiding this comment.
Suggested change
| [b]Note:[/b] On macOS, menu is activated by any mouse button, activation callback is not triggered. | |
| [b]Note:[/b] On Windows, menu is activated by right mouse button, selecting icon and pressing Shift+F10 or the applications key, activation callback for the other mouse buttons is still triggered. | |
| [b]Note:[/b] Native popup is supported only if [NativeMenu] supports [constant NativeMenu.FEATURE_POPUP_MENU] feature. | |
| [b]Note:[/b] On macOS, the menu is activated by any mouse button. Its activation callback is [i]not[/i] triggered. | |
| [b]Note:[/b] On Windows, the menu is activated by the right mouse button, selecting the status icon and pressing [kbd]Shift + F10[/kbd], or the applications key. The menu's activation callback for the other mouse buttons is still triggered. | |
| [b]Note:[/b] Native popup is only supported if [NativeMenu] supports the [constant NativeMenu.FEATURE_POPUP_MENU] feature. |
... What's the "selecting icon" and "applications key" though?
There was a problem hiding this comment.
"applications key" though?
This thing (it's referred in the Windows docs as "applications key").
What's the "selecting icon"
You can select tray icons with keyboard (using Windows + B, arrow keys and Enter).
There was a problem hiding this comment.
You learn something new every day... It may be worth mentioning the KEY_* constant equivalent if it does exist.
There was a problem hiding this comment.
Interesting, I always thought this was the context key.
…ve handling on macOS, add method to set native popup menu directly.
bruvzg
force-pushed
the
status_ind_menu_direct
branch
from
457df33
to
0587a1d
Compare
Riteo
reviewed
Apr 11, 2024
Riteo
approved these changes
Apr 30, 2024
AThousandShips
approved these changes
Apr 30, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Texture2Dinstead ofImage(as most other UI element do, breaking change from the previous dev release, but API was not present in any previous stable releases).DisplayServerand property toStatusIndicatornode) to set native popup menu directly, since this is a most common use for indicators (also to match https://www.freedesktop.org/wiki/Specifications/StatusNotifierItem/StatusNotifierItem/ for the future Linux implementation which might miss other ways to position popup).