[3.x] Fix building with disable_3d
#89565
Merged
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Mar 16, 2024
|
Tested with my own minimal template build similar to the PR linked above and it built properly so seems all the build configuration issues are solved on that side, with a minimal CI check this should be manageable in the future as well! |
lawnjelly
approved these changes
Mar 16, 2024
|
Sorry, must have missed this, thanks for fixing @AThousandShips . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We might want to look at adding a minimal template build to 3.x like we have for 4.x, if desired, the building there is relatively minimal at the moment but might be something to look intoEdit: Realized one exists already:
modules_enabled_by_defaultand minimal CI build #53489