C#: Implement InvariantCulture on Variant strings
#89547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulloz
reviewed
Mar 22, 2024
There was a problem hiding this comment.
Thanks for this 🙏
It has already been heavily discussed on Rocket.chat. Looks fine for me. I'm not sure that we usually do expression-bodied methods, but I don't really have a strong opinion. I think you missed a few of Edit: I'm simply bad at reading.real_t during the sweep. They're highlighted in other comments.
paulloz
approved these changes
Mar 23, 2024
raulsntos
approved these changes
Mar 23, 2024
There was a problem hiding this comment.
We discussed this to death and I think this PR represents the conclusion we reached, thank you so much for the work and being so patient.
Also, since this changes the behavior of these methods I'll add the breaks compat label so we remember to document it in the migration guide of whatever version this lands on.
akien-mga
closed this pull request by merging all changes
into
godotengine:master
in
06abc86
akien-mga
added a commit
that referenced
this pull request
Mar 24, 2024
C#: Implement `InvariantCulture` on Variant strings
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes #83159
Changes the current behavior of the C# strings using formatting from the current culture to an invariant representation. It was discussed whether to take this approach or
IFormattableto allow for string invariance, ultimately deciding that these strings aren't used in contexts where the culture information is relevant. If desired,IFormattableimplementation can be revisited at a later point.