Fix error where update wouldn't reconnect the signal it should have reconnected and led to errors and crash. #89447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
the
cherrypick:4.2
KoBeWi
reviewed
Mar 20, 2024
KoBeWi
reviewed
Mar 20, 2024
…econnected and led to errors and crash
ajreckof
force-pushed
the
fix-error-crash-on-change-type-root-after-external-changes
branch
from
51a1899
to
69e5e58
Compare
KoBeWi
reviewed
Mar 22, 2024
KoBeWi
approved these changes
Mar 22, 2024
akien-mga
added a commit
that referenced
this pull request
Mar 24, 2024
…e-root-after-external-changes Fix error where update wouldn't reconnect the signal it should have reconnected and led to errors and crash.
akien-mga
closed this pull request by merging all changes
into
godotengine:master
in
06abc86
|
Thanks! |
AThousandShips
removed
the
cherrypick:4.2
|
Removing cherry-pick for now as this introduces a regression, see: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #78372 fixes #89425
The second issue is half a duplicate as it is the same issue but the symptoms degenerated over time from simple errors to a full crash.