Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

harfbuzz: Update to 8.3.0 #89304

Merged
merged 1 commit into from
Mar 11, 2024
Merged

harfbuzz: Update to 8.3.0 #89304

merged 1 commit into from
Mar 11, 2024

Conversation

Chubercik
Copy link
Contributor

@Chubercik Chubercik requested a review from a team as a code owner March 9, 2024 00:58
@AThousandShips AThousandShips added this to the 4.x milestone Mar 9, 2024
fire
fire approved these changes Mar 10, 2024
View reviewed changes
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a library upgrade and a stable release.

@bruvzg Might want to look, but it seems low risk.

@akien-mga
Copy link
Member

akien-mga commented Mar 10, 2024 •
edited
Loading

Could you squash the commits? See PR workflow for instructions.

Edit: Issue closing was a misclick.

@akien-mga akien-mga closed this Mar 10, 2024
@akien-mga akien-mga reopened this Mar 10, 2024
@akien-mga akien-mga modified the milestones: 4.x, 4.3 Mar 10, 2024
@akien-mga akien-mga requested a review from bruvzg March 10, 2024 20:06
@Chubercik
Copy link
Contributor Author

See PR workflow for instructions.

this_isnt_my_first_rodeo_mr_stark

@akien-mga akien-mga merged commit befc738 into godotengine:master Mar 11, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@Chubercik Chubercik deleted the harfbuzz-8.3.0 branch March 11, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips left review comments

@fire fire fire approved these changes

@akien-mga akien-mga akien-mga approved these changes

@bruvzg bruvzg Awaiting requested review from bruvzg

Assignees
No one assigned
Labels
enhancement topic:thirdparty
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@Chubercik @akien-mga @fire @AThousandShips