Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCons: Set silence_msvc to false by default #89159

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

Repiteo
Copy link
Contributor

@Repiteo Repiteo commented Mar 4, 2024

Because MSVC sometimes outputs errors onto stdout instead of stderr for some ungodly reason, the silence_msvc option isn't the surefire workaround I first thought. Left the functionality as-is for now, but changed the description to warn about potentially hiding error messages & made the default setting false.

@Calinou
Copy link
Member

Calinou commented Mar 4, 2024

Can we detect if stdout line printed by MSVC is of form path/to/file.something (with nothing else on the line), and only silence it in that case? I think this would be preferable to making #87154 ineffective by default.

@Repiteo
Copy link
Contributor Author

Repiteo commented Mar 4, 2024

I imagine that's possible, but I'm unsure how to do that atm; this is very much a short-term solution PR

@akien-mga akien-mga merged commit 0eee734 into godotengine:master Mar 5, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@Repiteo Repiteo deleted the suppress-msvc-false-default branch March 5, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants