Improve how Project & Editor Settings look in built-in docs #89086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mickeon
force-pushed
the
documentation-ProjectSettings-members-display-nice
branch
from
fa87835
to
fc617eb
Compare
akien-mga
reviewed
Mar 2, 2024
akien-mga
reviewed
Mar 2, 2024
editor/editor_help.cpp
Outdated
Comment on lines
2508
to
2514
| String setting_name = link_target.trim_prefix("ProjectSettings.").trim_prefix("EditorSettings."); | ||
| PackedStringArray setting_sections; | ||
| for (const String §ion : setting_name.split("/", false)) { | ||
| setting_sections.append(EditorPropertyNameProcessor::get_singleton()->process_name(section, EditorPropertyNameProcessor::STYLE_CAPITALIZED)); | ||
| } |
There was a problem hiding this comment.
You're opening a can of worms here :)
Two things would need to be taken into account:
- Localization
- The configured capitalization style (
EditorPropertyNameProcessor::get_settings_style())
CC @timothyqiu
There was a problem hiding this comment.
Yeah, using EditorPropertyNameProcessor::get_settings_style() would solve both. It takes localization into account.
Mickeon
force-pushed
the
documentation-ProjectSettings-members-display-nice
branch
from
fc617eb
to
e9cbafa
Compare
timothyqiu
reviewed
Mar 3, 2024
Mickeon
force-pushed
the
documentation-ProjectSettings-members-display-nice
branch
from
e9cbafa
to
8e10245
Compare
|
Should be good now. |
|
We should probably make a similar change to |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL:DR:
Code could be better but it does work!