Move rendering/2d/snap/snap_2d_vertices_to_pixel setting to advanced view
#88963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
changed the title
rendering/2d/snap/snap_2d_vertices_to_pixel setting to advanced viewrendering/2d/snap/snap_2d_vertices_to_pixel setting to advanced view
AThousandShips
approved these changes
Feb 28, 2024
Mickeon
reviewed
Feb 28, 2024
adamscott
force-pushed
the
hide-to-advanced-snap-2d-vertices
branch
from
507621e
to
dcf4cf7
Compare
|
Thanks! |
I tried this PR, and I'm still getting considerable sprite bleed with snap transforms to pixel enabled ( #67164 ), while snap vertices to pixel is almost entirely bleed free. So there's definitely a current use case where vertex snapping works a lot better - I don't think hiding the old setting in 'advanced' is really justified when the replacement doesn't fix the same problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #88456. (I wanted to comment on that PR but I completely forgot about this.)
This PR hides
rendering/2d/snap/snap_2d_vertices_to_pixelfrom the basic settings view.rendering/2d/snap/snap_2d_transforms_to_pixelwas overhauled with #87297, and that makesrendering/2d/snap/snap_2d_vertices_to_pixelsomewhat unneeded.So, by hiding the latter setting, we make sure that people would only activate the relevant one.
Also edited the documentation in order to reflect on that.
cc. the original author of #88456, @sabslikesobs