Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong indexing when generating dummy tangents in GLTF import #88931

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

clayjohn
Copy link
Member

@clayjohn clayjohn commented Feb 27, 2024

Fixes: #88903
Follow-up to #88738.

I couldn't reproduce the crash, but I am quite confident this is the problem. i is used for the index of the mesh in the GLTF file, so this line will crash whenever a mesh has a smaller number of vertices than its index in the GLTF file.

@clayjohn clayjohn added this to the 4.3 milestone Feb 27, 2024
@clayjohn clayjohn requested a review from a team as a code owner February 27, 2024 19:46
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm this solves the crash for me.

@akien-mga akien-mga merged commit ac43768 into godotengine:master Feb 27, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Mar 9, 2024
@akien-mga
Copy link
Member

Cherry-picked for 4.2.2.

@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash in GLTFDocument::_parse_meshes when importing TPS demo
2 participants