Add browse folder and browse file icons

[adamscott]

Adds the missing "browse folder" and "browse file" icons and replaces the "Browse" text button of the ProjectDialog, and the FBXImporterManager to an icon button.

New icons: and

I opened the folder icon in Inkscape ( editor/icons/Folder.svg), created circles of 1px of radius, then created an outline of 1px. Subtracted the outline from the folder icon.

Before	After

Relates to #88825

Edits

• 2024-02-26
  • Added the "browse file" icon
  • Added the browse file to the FBXImporterManager dialog.
  • Added the browse folder to the EditorFileSystemImportFormatSupportQueryBlend dialog.
• 2024-02-28
  • Changed editor settings icons depending on what is needed
• 2024-03-07
  • Added back labels to buttons.

[Mickeon]

My thoughts are the same as #88825 (review)

[MewPurPur]

This one requires a lot more spacing between the folder and the dots, as it's not grid-aligned or multicolored. I think it'll look better if we make the circles a bit bigger too.

[adamscott]

I added more space between the dots and the icon (moved from 1px to 1.5px).

And I added the browse file icon!

[adamscott]

I added the browse folder icon to the EditorFileSystemImportFormatSupportQueryBlend dialog. This should wrap up all the "browse" buttons.

[MewPurPur]

LGTM (literally)

[AThousandShips]

Could you try adding it here too?

godot/editor/editor_resource_picker.cpp

Lines 197 to 201 in bb6b06c

	edit_menu->add_icon_item(get_editor_theme_icon(SNAME("Load")), TTR("Quick Load..."), OBJ_MENU_QUICKLOAD);
	edit_menu->set_item_tooltip(-1, TTR("Opens a quick menu to select from a list of allowed Resource files."));
	// Add an option to load a resource from a file using the regular file dialog.
	edit_menu->add_icon_item(get_editor_theme_icon(SNAME("Load")), TTR("Load..."), OBJ_MENU_LOAD);

[adamscott]

Could you try adding it here too?

godot/editor/editor_resource_picker.cpp

Lines 197 to 201 in bb6b06c

	edit_menu->add_icon_item(get_editor_theme_icon(SNAME("Load")), TTR("Quick Load..."), OBJ_MENU_QUICKLOAD);
	edit_menu->set_item_tooltip(-1, TTR("Opens a quick menu to select from a list of allowed Resource files."));
	// Add an option to load a resource from a file using the regular file dialog.
	edit_menu->add_icon_item(get_editor_theme_icon(SNAME("Load")), TTR("Load..."), OBJ_MENU_LOAD);

I don't think this PR obsoletes the load logo . I think that this PR means to replace the "Browse" text buttons, which don't load/open by themselves files, but only sets the path in the field.

[AThousandShips]

True, this case here is still more a browse as it assigns a resource from a load, not opens it for editing as such

[adamscott]

@akien-mga Makes me think that I could create a PR to remove the FBX importer dialog as ufbx was merged. The dialog is plain wrong.

[adamscott]

True, this case here is still more a browse as it assigns a resource from a load, not opens it for editing as such

How do we summon this edit menu already?

[AThousandShips]

It's in the inspector, when you have a resource

[adamscott]

@AThousandShips But this replaces the current resource, effectively loading it.

[AThousandShips]

It loads it in the sense that it opens it in memory, but the main purpose is to replace the resource there, so I'd say it's the same as browsing for a file path, but it was just an idea :)

It doesn't replace the current resource, just the resource in the property

[Calinou]

Should we use this new icon for file/directory properties in EditorInspector (e.g. in the Editor Settings)?

[adamscott]

Should we use this new icon for file/directory properties in EditorInspector (e.g. in the Editor Settings)?

@Calinou Done! See the updated images on the PR description.

[adamscott]

@Mickeon @MewPurPur @akien-mga Following this comment, I added back text labels for the "create project" dialog, the Blender dialog and the FBX dialog. See the PR description for the updated images.

[akien-mga]

Looks good to me.

[Mickeon]

All is well what ends well

[akien-mga]

Thanks!