Dictionary Editor: Keep the type of the last added item. #88636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
changed the title
Calinou
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
Tested locally, it works as expected.
simplescreenrecorder-2024-02-21_20.07.01.mp4
Code looks good to me.
For a future PR, we should look into disabling the Add Key/Value Pair button (with a tooltip explaining why) until a type other than Nil is assigned to the key.
Mickeon
approved these changes
Feb 21, 2024
This is planned but not only for null but also for already existing key. |
|
Thanks! |
This was referenced Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small step towards #76078
This avoid selecting the type of the key and value each time you want to add an element. This one of the most wanted feature and also one of the easiest towards #76078