Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for Camera2D #88614

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Add unit tests for Camera2D #88614

merged 1 commit into from
Apr 10, 2024

Conversation

ramadm
Copy link
Contributor

@ramadm ramadm commented Feb 21, 2024

This PR adds unit tests for Camera2D, mentioned in issue #43440.

@ramadm ramadm requested a review from a team as a code owner February 21, 2024 01:59
@Calinou Calinou added this to the 4.x milestone Feb 21, 2024
@Calinou Calinou mentioned this pull request Feb 21, 2024
Open
99 tasks
Calinou
Calinou approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally (rebased on top of master 6c57928), it works as expected. Code looks good to me.

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Apr 10, 2024
@akien-mga akien-mga merged commit 4b81338 into godotengine:master Apr 10, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou approved these changes

Assignees
No one assigned
Labels
enhancement topic:tests
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@ramadm @akien-mga @Calinou