Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail early if shader mode is invalid in dummy renderer #88581

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Fail early if shader mode is invalid in dummy renderer #88581

merged 1 commit into from
Feb 23, 2024

Conversation

jsjtxietian
Copy link
Contributor

Fixes #87812 cc @clayjohn

@jsjtxietian jsjtxietian requested a review from a team as a code owner February 20, 2024 04:01
@Chaosus Chaosus added this to the 4.3 milestone Feb 20, 2024
@akien-mga akien-mga merged commit b82855b into godotengine:master Feb 23, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Apr 16, 2024
@akien-mga
Copy link
Member

Cherry-picked for 4.2.2.

@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips approved these changes

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
bug crash topic:rendering
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Executing Shader.set_code function crashes Godot (Headless)
5 participants
@jsjtxietian @akien-mga @clayjohn @AThousandShips @Chaosus