Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix owner when importing meshes #88497

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

Sauermann
Copy link
Contributor

@Sauermann Sauermann commented Feb 18, 2024

Handle the case correctly, that a child of a replaced node has as owner an ancestor of the replaced node.

resolve #88125

regression from #78997 which got cherry-picked to 4.2.

@Sauermann Sauermann requested a review from a team as a code owner February 18, 2024 14:23
@Sauermann Sauermann added this to the 4.3 milestone Feb 18, 2024
@akien-mga akien-mga added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Feb 18, 2024
@fire fire requested a review from a team February 26, 2024 21:19
Handle the case correctly, that a child of a replaced node has
as owner an ancestor of the replaced node.
@akien-mga akien-mga merged commit 3dca3c2 into godotengine:master Feb 27, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@Sauermann Sauermann deleted the fix-owner-import branch February 27, 2024 20:57
@akien-mga
Copy link
Member

Cherry-picked for 4.2.2.

@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing glTF with nested structure gives "inconsistent owner" warning
3 participants