C#: Match Core implementation of BinToInt & HexToInt
#88453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulsntos
approved these changes
Feb 17, 2024
There was a problem hiding this comment.
Thanks. This matches the Core behavior:
- Add error messages to
String::hex_to_int, and accept capital X in prefix #54078 - Accept capital B in
String::bin_to_intprefix #54081
This should be safe to cherry-pick since the previous behavior was throwing an exception so it doesn't break compat.
raulsntos
added
cherrypick:4.1
|
Thanks! |
|
Cherry-picked for 4.2.2. |
akien-mga
removed
cherrypick:4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the functions
BinToInt&HexToIntto properly account for different casings by addingStringComparison.OrdinalIgnoreCaseto both, matching the Core implementation