Unbind GDExtension methods that can't reasonably be used #88418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mickeon
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
I love documenting things because it's only when you actually do it that you realise there's a some sort of problem with the way things are done.1234567.
Footnotes
akien-mga
approved these changes
Feb 16, 2024
dsnopek
force-pushed
the
gdextension-unbind-methods
branch
from
af7a234
to
99fd6ca
Compare
|
Thanks! |
|
Rewrite everyone's extensions again... |
Unless an extension called one of the 3 specific method unbound here (which I doubt any extension did because they can't really be used in any reasonable way), then no changes will be needed. |
or uses load-on-init pattern 😁 but it was quick to adjust. |
akien-mga
added a commit
that referenced
this pull request
May 30, 2024
Bind compatibility GDExtension methods removed in #88418
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the GDExtension meeting on January 26th, 2024 (see notes) we agreed to unbind a number of methods on the
GDExtensionclass that can't reasonably be used by developers.These methods include:
GDExtension::open_library()GDExtension::initialize_library()GDExtension::close_library()A developer could maybe have partially correctly loaded and initialized a GDExtension using
open_library()and then callinginitialize_library()with each initialization level. However, a number of other important things are managed by usingGDExtensionManager::load_extension(), which this would bypass. Strangely, we never bounddeinitialize_library()(the opposite toinitialize_library()), so a developer could not have closed a GDExtension properly using these APIs.Anyway, developers should be using
GDExtensionManager::load_extension()andGDExtensionManager::unload_extension()to correctly load and unload a GDExtension.Since it's basically impossible to use the methods being unbound by this PR in any useful way, we agreed at the meeting that we didn't need to provide compatibility methods for them.
This discussion started from PR #86968 which was attempting to document the methods in question