Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dummy rendering server appear as a high end platform to fix vulkan shader compile error when exporting #88409

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

jsjtxietian
Copy link
Contributor

@jsjtxietian jsjtxietian commented Feb 16, 2024

Fixes #88187 as #88187 (comment) suggested, tested locally it eliminates the shader compilation error reported.

 to fix vulkan shader compile error when exporting
@jsjtxietian jsjtxietian requested a review from a team as a code owner February 16, 2024 16:01
@akien-mga akien-mga added this to the 4.3 milestone Feb 16, 2024
@akien-mga akien-mga merged commit 1b8e12c into godotengine:master Feb 16, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@jsjtxietian jsjtxietian deleted the high-end branch February 17, 2024 05:39
@akien-mga akien-mga added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Mar 6, 2024
@akien-mga
Copy link
Member

Cherry-picked for 4.2.2.

@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants