Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Bezier Editor throwing error when adding key with Ctrl+Click #88360

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Fix Bezier Editor throwing error when adding key with Ctrl+Click #88360

merged 1 commit into from
Feb 15, 2024

Conversation

CookieBadger
Copy link
Contributor

fixes #87861

@AThousandShips AThousandShips requested a review from a team February 15, 2024 13:51
@AThousandShips AThousandShips added this to the 4.3 milestone Feb 15, 2024
@akien-mga akien-mga added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Feb 15, 2024
@CookieBadger
Copy link
Contributor Author

I don't really know how cherry-picking works yet, but note that this code relies on the make_default_bezier_key method I added in the copy-paste PR #87250

@akien-mga
Copy link
Member

Thanks for the headsup. That other PR likely won't be cherry-picked, so it might be worth making a dedicated backport of this PR for the 4.2 branch to fix the bug there, keeping the manually defined array.

@akien-mga akien-mga merged commit e42141f into godotengine:master Feb 15, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@CookieBadger CookieBadger deleted the bezier-ctrl-click-add-key-fix branch February 18, 2024 20:02
@akien-mga
Copy link
Member

akien-mga commented Mar 11, 2024 •
edited
Loading

Cherry-picked for 4.2.2.

Edit: Actually no, as discussed above this needs a dedicated backport.

@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Mar 11, 2024
@CookieBadger CookieBadger mentioned this pull request Mar 18, 2024
Merged
@akien-mga akien-mga changed the title Fix Bezier Editor throwing error when adding key with CTRL+click Fix Bezier Editor throwing error when adding key with Ctrl+Click Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:animation topic:editor
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Adding a Keyframe with Ctrl+Click in Animation Bezier Editor throws error
3 participants
@CookieBadger @akien-mga @AThousandShips