Enable getting suggested tracker names from OpenXR extensions #88311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4gr3d
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
The logic looks good to me.
Leaving it up to @BastiaanOlij to comment on the design.
BastiaanOlij
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
Looks perfect.
The only issue, but I think that should get its own PR and we already have an issue for this, is that the eye gaze interaction extension is currently only instanced if the eye gaze extension is enabled in project settings.
This needs to change, we should always instantiate the extension, but only enable it, as the meta data should always be registered. The tracker names are a bit of a grey area here as nothing will fall over if they are not among the suggested names.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves some of the hard-coded positional tracker names into their corresponding extension wrappers, and exposes them with their own
get_suggested_tracker_names()function. Necessary if any vendor specific extensions like the one in GodotVR/godot_openxr_vendors#81 want to add suggested names.