Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CanvasItem/Node3D editor plugin drag drop transform calculation #88279

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Fix CanvasItem/Node3D editor plugin drag drop transform calculation #88279

merged 1 commit into from
Feb 13, 2024

Conversation

kleonc
Copy link
Member

@kleonc kleonc commented Feb 13, 2024

Fixes a regression from #86659/#88269 caused by using transform methods working only for orthonormal transforms.

Before
(master)		 After
(this PR)
GHSAIEe1dz jI2ldRoSyX
YjQtM2WRoi Qr9ES9PfkR

@kleonc kleonc added this to the 4.3 milestone Feb 13, 2024
@kleonc kleonc requested a review from a team as a code owner February 13, 2024 12:58
@akien-mga
Copy link
Member

CC @MajorMcDoom

@MajorMcDoom
Copy link
Contributor

MajorMcDoom commented Feb 13, 2024 •
edited
Loading

Thank you for catching this, it was my bad. I am new and assumed xform_inv would support affine transformations.

@akien-mga akien-mga merged commit e0b1e79 into godotengine:master Feb 13, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@kleonc kleonc deleted the editor-plugins-2d3d-drag-drop-transform-calculation-fix branch February 13, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryevdokimov ryevdokimov ryevdokimov approved these changes

Assignees
No one assigned
Labels
bug regression topic:editor topic:2d topic:3d
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@kleonc @akien-mga @MajorMcDoom @ryevdokimov