-
-
Notifications
You must be signed in to change notification settings - Fork 21.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix update property for dictionaries so that it updates only what is necessary. #88231
Conversation
5dc1034
to
fcd1d4e
Compare
It breaks dragging elements to other pages: godot.windows.editor.dev.x86_64_f34FnBck1Z.mp4 |
fcd1d4e
to
fa4c0d7
Compare
Fixed |
fa4c0d7
to
625ac20
Compare
d6ae21d
to
08b8782
Compare
It's still a little bugged 🤔 godot.windows.editor.dev.x86_64_ThlgrE8Clj.mp4The original element gets focused once drag ends. But at least it's moved correctly, so maybe it's fine for now. |
void set_index(int p_idx) { | ||
index = p_idx; | ||
switch (index) { | ||
case -2: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The magic number should likely be replaced with a constant.
This was not introduced by this PR(present on master). Should be easy to fix though. Do you think I should add the fix in this PR or create a separate issue/PR? |
If it's pre-existing, you can open an issue (if it wasn't reported already). |
08b8782
to
0331ecb
Compare
Fix update property for dictionaries so that it updates only what is necessary.
06abc86
Thanks! |
This is the dictionary counter part of #80706.
update_property
for array #80706 (comment))This is a small step towards #76078 as I decided to break it into smaller pieces for it to be easier to make and review.
The last part could be removed from this PR if needed, I would then update #87140 once this PR is merged with what I removed from here. See #87140 (comment) for why the array parts are linked to dictionnary parts