Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix data race regarding prof_time in AudioDriver and AudioServer #88005

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Fix data race regarding prof_time in AudioDriver and AudioServer #88005

merged 1 commit into from
Feb 7, 2024

Conversation

jsjtxietian
Copy link
Contributor

@jsjtxietian jsjtxietian commented Feb 6, 2024 •
edited by akien-mga
Loading

@jsjtxietian jsjtxietian requested a review from a team as a code owner February 6, 2024 03:31
@akien-mga akien-mga added this to the 4.3 milestone Feb 6, 2024
akien-mga
akien-mga reviewed Feb 6, 2024
View reviewed changes
servers/audio_server.h Outdated Show resolved Hide resolved
akien-mga
akien-mga approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@akien-mga akien-mga merged commit 9346094 into godotengine:master Feb 7, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@jsjtxietian jsjtxietian deleted the audio-data-race branch February 7, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RandomShaper RandomShaper RandomShaper left review comments

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:audio
Projects
None yet
Milestone
4.3
3 participants
@jsjtxietian @akien-mga @RandomShaper