Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] Check Vulkan SDK version when looking for MoltenVK libs. #87960

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Feb 4, 2024

Add min. supported Vulkan SDK version check to avoid linking errors with old SDKs.

@bruvzg bruvzg added this to the 4.3 milestone Feb 4, 2024
@bruvzg bruvzg requested a review from a team as a code owner February 4, 2024 21:13
@akien-mga akien-mga added cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Feb 5, 2024
@akien-mga akien-mga merged commit 6f2adcd into godotengine:master Feb 5, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 4.2.2.
Cherry-picked for 4.1.4.

@akien-mga akien-mga removed cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants