Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add null check for GDExtension deinitialization #87938

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Add null check for GDExtension deinitialization #87938

merged 1 commit into from
Feb 5, 2024

Conversation

tishin
Copy link
Contributor

@tishin tishin commented Feb 4, 2024

Fixes #87937

@tishin tishin requested a review from a team as a code owner February 4, 2024 11:44
@tishin tishin mentioned this pull request Feb 4, 2024
Open
@AThousandShips AThousandShips added this to the 4.3 milestone Feb 4, 2024
AThousandShips
AThousandShips approved these changes Feb 4, 2024
View reviewed changes
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me, is symmetrical with the initialize_library code so seems like a simple oversight

CC @dsnopek

@AThousandShips AThousandShips added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Feb 4, 2024
@AThousandShips
Copy link
Member

AThousandShips commented Feb 4, 2024 •
edited
Loading

Can you please squash your commits into one, see here

@akien-mga akien-mga changed the title Add null check for gdextension deinitialization Add null check for GDExtension deinitialization Feb 5, 2024
@akien-mga akien-mga merged commit f4f1398 into godotengine:master Feb 5, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 4.2.2.

@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips approved these changes

Assignees
No one assigned
Labels
bug crash topic:gdextension
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

GDExtension hot reload does not check for null in initialization.deinitialize
3 participants
@tishin @AThousandShips @akien-mga