Throw exception when solution file is missing during exporting #87829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can't do this because it would prevent non-C# projects from being exported. The C# version of Godot should still allow creating and exporting GDScript-only games, this becomes more important as we try to unify the two versions of the Godot editor. |
nongvantinh
force-pushed
the
fix-86591
branch
2 times, most recently
from
1c56cc3
to
fcdb5e5
Compare
akien-mga
approved these changes
Apr 6, 2024
There was a problem hiding this comment.
The new commit seems to address @raulsntos' concern and makes sense to me.
I'll let you double check Raul.
raulsntos
reviewed
Apr 6, 2024
modules/mono/editor/GodotTools/GodotTools/Export/ExportPlugin.cs
Outdated
Show resolved
Hide resolved
modules/mono/editor/GodotTools/GodotTools/Export/ExportPlugin.cs
Outdated
Show resolved
Hide resolved
Fixes: godotengine#86591 Co-authored-by: Raul Santos <[email protected]>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #86591