Reorganize project manager code #87266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extract individual components to their own files. - Improve order of declarations and definitions within those files. - ProjectDialog is only extracted as there are upcoming PRs touching on it.
YuriSizov
force-pushed
the
pm-gets-a-chris-hemsworth-treatment
branch
from
1306d8b
to
691450b
Compare
akien-mga
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Looks great!
In a follow-up, we could consider moving project_manager.cpp to the subfolder, even though the repeated name is a bit awkward.
On the other hand, we have this pattern in other platforms of having a subfolder with a similar name as a top-level class, e.g. servers/rendering_server.h/servers/rendering/*, so maybe it's fine as is.
I did consider it, but since it's the entry point, same as |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlights
Note that
ProjectDialogis only extracted without any further touchup, as there is an upcoming PR touching on it, #56420. I wanted to wait for @nathanfranke to finish his first, but it's been a few weeks, so I settled for making the changes as simple to adapt to as possible.There are going to be some more exciting PRs based on this one in the near future.