Fix Dummy audio driver initialization issue on WASAPI output device initialization failure

[alessandrofama]

AudioDriverWASAPI::init consistently returns Error::OK, even when encountering a failure during the initialization of the output device. This behaviour blocks the dummy driver from initializing in AudioDriverManager::initialize. Fixes #71640.

[AThousandShips]

Makes sense otherwise, and other drivers exit this way as well

[AThousandShips]

Unsure if this should be moved up, it is above in the alsa code and could cause threading problems if not fired with this change, it's put at the top in some cases, I don't know what the exact structure should be for that

[alessandrofama]

I can see it's above in the output initialisation of the alsa & pulseaudio drivers. The flag is only set in the thread entry point and in AudioDriverWASAPI::finish. Not sure about the structure too. Could be moved up for consistency.

[alessandrofama]

moved it up

[akien-mga]

Thanks!

[akien-mga]

The original bug report was against 3.5.1, but this PR doesn't seem applicable to the 3.x code, which currently looks like this:

Error AudioDriverWASAPI::init() {
        mix_rate = GLOBAL_GET("audio/mix_rate");

        Error err = init_render_device();
        if (err != OK) {
                ERR_PRINT("WASAPI: init_render_device error");
        }

        exit_thread.clear();

        thread.start(thread_func, this);

        return OK;
}

@alessandrofama Would you be up for checking whether the issue is still reproducible in 3.x and thus how to solve it there?

[alessandrofama]

@alessandrofama Would you be up for checking whether the issue is still reproducible in 3.x and thus how to solve it there?

Yes, it was reproducible. Created a PR :)

[YuriSizov]

Cherry-picked for 4.2.2.

[YuriSizov]

Cherry-picked for 4.1.4.