Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made tooltip on TileSet Paint Button give more information when disabled #86947

Merged
merged 1 commit into from
Jun 4, 2024
+11 −9
Merged

Made tooltip on TileSet Paint Button give more information when disabled #86947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions editor/plugins/tiles/tile_set_atlas_source_editor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1046,6 +1046,13 @@ void TileSetAtlasSourceEditor::_update_toolbar() {
}
}

void TileSetAtlasSourceEditor::_update_buttons() {
tool_paint_button->set_disabled(read_only);
tool_paint_button->set_tooltip_text(read_only ? TTR("TileSet is in read-only mode. Make the resource unique to edit TileSet properties.") : TTR("Paint properties."));
tools_settings_erase_button->set_disabled(read_only);
tool_advanced_menu_button->set_disabled(read_only);
}

void TileSetAtlasSourceEditor::_tile_atlas_control_mouse_exited() {
hovered_base_tile_coords = TileSetSource::INVALID_ATLAS_COORDS;
tile_atlas_control->queue_redraw();
Expand Down Expand Up @@ -2212,10 +2219,7 @@ void TileSetAtlasSourceEditor::edit(Ref<TileSet> p_tile_set, TileSetAtlasSource
tool_setup_atlas_source_button->set_pressed(true);
}

// Disable buttons in read-only mode.
tool_paint_button->set_disabled(read_only);
tools_settings_erase_button->set_disabled(read_only);
tool_advanced_menu_button->set_disabled(read_only);
_update_buttons();

// Update everything.
_update_source_inspector();
Expand Down Expand Up @@ -2429,10 +2433,7 @@ void TileSetAtlasSourceEditor::_notification(int p_what) {
read_only = EditorNode::get_singleton()->is_resource_read_only(tile_set);
}

// Disable buttons in read-only mode.
tool_paint_button->set_disabled(read_only);
tools_settings_erase_button->set_disabled(read_only);
tool_advanced_menu_button->set_disabled(read_only);
_update_buttons();

// Update everything.
_update_source_inspector();
Expand Down Expand Up @@ -2516,7 +2517,6 @@ TileSetAtlasSourceEditor::TileSetAtlasSourceEditor() {
tool_paint_button->set_theme_type_variation("FlatButton");
tool_paint_button->set_toggle_mode(true);
tool_paint_button->set_button_group(tools_button_group);
tool_paint_button->set_tooltip_text(TTR("Paint properties."));
toolbox->add_child(tool_paint_button);

// Tile inspector.
Expand Down Expand Up @@ -2618,6 +2618,7 @@ TileSetAtlasSourceEditor::TileSetAtlasSourceEditor() {
tool_settings->add_child(outside_tiles_warning);

_update_toolbar();
_update_buttons();

// Right side of toolbar.
Control *middle_space = memnew(Control);
Expand Down
1 change: 1 addition & 0 deletions editor/plugins/tiles/tile_set_atlas_source_editor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,7 @@ class TileSetAtlasSourceEditor : public HSplitContainer {
void _update_manage_tile_properties_button();
void _update_atlas_view();
void _update_toolbar();
void _update_buttons();

// -- Misc --
void _auto_create_tiles();
Expand Down
Loading