Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post-merge fixes to Node & OS documentation #86903

Merged

Conversation

Mickeon
Copy link
Contributor

@Mickeon Mickeon commented Jan 6, 2024

Closes #86813

This PR picks up from #68560 and #80282, adding more details, addressing a few inaccuracies and poor wording.

For Node:

  • Adds missing descriptions to the ProcessThreadMessages flag constants, finally filling them all.
  • Moves a detail of set_process, set_physics_process etc. into their own note and specifies that they're automatically called before _ready.
  • Changes an error in name's description:
    • When the original PR was made, invalid characters were removed from a Node name. As time passed, this behavior was changed but the description was not.
  • Clarifies DUPLICATE_SCRIPTS' behavior.
    • I have no idea what the original PR's description meant. It's nonsense, in hindsight.

For OS:

I wanted to rewrite all of the Node thread-related descriptions here (when the original PR was made they did not exist yet), but I'm leaving that for another time.

@Mickeon
Copy link
Contributor Author

Mickeon commented Feb 11, 2024

Rebased after #82889 .

@Mickeon Mickeon force-pushed the Post-merge-fixes-to-Node-documentation branch from 9817f16 to e26f612 Compare February 11, 2024 15:44
@akien-mga akien-mga merged commit 679fa26 into godotengine:master Feb 12, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@Mickeon Mickeon deleted the Post-merge-fixes-to-Node-documentation branch February 13, 2024 15:55
@Mickeon Mickeon added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release documentation enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OS.read_string_from_stdin() switches contexts when running without console wrapper from a console.
4 participants