Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In merge_with also merge some default fields of theme #86894

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

jsjtxietian
Copy link
Contributor

Fixes #86857

I'm not sure whether merge_with should take care of these default fields, feel free to correct me.

Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that makes sense.

@akien-mga akien-mga merged commit 1d3f98a into godotengine:master Jan 9, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@jsjtxietian jsjtxietian deleted the merge-dafault-font branch January 9, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Theme.merge_with does not seem to merge the default font size
4 participants