Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Autocompletion for AnimationNodeStateMachine & AnimationNodeBlendTree #86884

Merged

Conversation

Mickeon
Copy link
Contributor

@Mickeon Mickeon commented Jan 6, 2024

Related to #86799 and #86754

This PR adds auto completion to AnimationNodeStateMachine's state-related methods, as well as AnimationNodeBlendTree's node-fetching related methods.

image
image

These are not to be confused with AnimationNodeStateMachinePlayback's methods, which unfortunately isn't natively possible to do without further meddling, as it does not have a direct reference to its origin state machine (I tried, I promise).

@Mickeon Mickeon requested a review from a team as a code owner January 6, 2024 15:46
@TokageItLab TokageItLab requested a review from a team January 6, 2024 15:50
@TokageItLab TokageItLab added this to the 4.x milestone Jan 6, 2024
@Mickeon Mickeon force-pushed the autocompletion-AnimationNodeStateMachine branch from caadcf5 to e5c1da1 Compare January 6, 2024 16:03
@Mickeon
Copy link
Contributor Author

Mickeon commented Jan 6, 2024

One of the checks failed for seemingly no reason.

@AThousandShips
Copy link
Member

GHA seems to have some sporadic issues with network, I suspect a service issue or an attack, or some broken CI somewhere

Copy link
Member

@TokageItLab TokageItLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unlike #86888, this PR seems to make more sense.

@TokageItLab TokageItLab modified the milestones: 4.x, 4.3 Feb 11, 2024
@akien-mga akien-mga merged commit 2853b57 into godotengine:master Feb 12, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@Mickeon Mickeon deleted the autocompletion-AnimationNodeStateMachine branch February 13, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants