-
-
Notifications
You must be signed in to change notification settings - Fork 21.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Editor] Add missing virtual bind to EditorNode3DGizmo(Plugin)
#86881
Conversation
916090f
to
a42f459
Compare
EditorNode3DGizmoPlugin
EditorNode3DGizmo(Plugin)
a42f459
to
5268b9c
Compare
<return type="void" /> | ||
<param index="0" name="id" type="int" /> | ||
<param index="1" name="secondary" type="bool" /> | ||
<description> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would appreciate any details on what this should do, as I don't know what it does, the base method isn't exposed so no information is available
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CC @KoBeWi who added this AFAICT.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was added in #71092
It's called when a user clicks the gizmo and can be used to fetch and store initial values.
There are potentially a few other missing binds across the engine, did a casual search, this one turned up: godot/scene/resources/primitive_meshes.h Line 626 in 89cc635
Will see about another improvement to bind them (that one should probably also be moved into the protected scope) |
5268b9c
to
49ad775
Compare
Method `_begin_handle_action` was not bound
49ad775
to
c794ce1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know the specifics of this particular node, but looking at the code, it's clear that these methods were intended to be exposed to GDExtension (it's got the GDVIRTUAL*()
and GDVIRTUAL_CALL()
) but that the GDVIRTUAL_BIND()
was just forgotten.
So, I can't help with the docs, but the functional code looks good!
Thanks! |
Thank you! |
Cherry-picked for 4.2.2. |
Method
_begin_handle_action
was not boundEditorNode3DGizmoPlugin::begin_handle_action
not registered to ClassDB #86880