Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link to mentioned articles in the docs instead of just naming them #86666

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Link to mentioned articles in the docs instead of just naming them #86666

merged 1 commit into from
Jan 2, 2024

Conversation

Mickeon
Copy link
Contributor

@Mickeon Mickeon commented Dec 31, 2023

Very simple nuisances that had been peeving me for a while. Without the direct links, it forces the users to look around the internet, even though the author clearly intended for a specific page to be seen.

These were the only 4 times the class reference said "article" by the way.

image

@Mickeon Mickeon requested a review from a team as a code owner December 31, 2023 13:08
@Mickeon Mickeon force-pushed the merge-this-before-2024-i-bet-you-wont branch from 451efdd to 06e86f5 Compare December 31, 2023 13:18
@dalexeev dalexeev added enhancement documentation cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Dec 31, 2023
@dalexeev dalexeev added this to the 4.3 milestone Dec 31, 2023
aaronfranke
aaronfranke approved these changes Dec 31, 2023
View reviewed changes
Copy link
Member

@aaronfranke aaronfranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am the reason all of these were added, thanks for improving it by linking to the pages.

akien-mga
akien-mga reviewed Jan 2, 2024
View reviewed changes
doc/classes/Basis.xml Outdated Show resolved Hide resolved
@akien-mga akien-mga changed the title Link to the "article" in the docs instead of saying "article" Link to the "article" in the docs instead of just naming it Jan 2, 2024
@akien-mga akien-mga changed the title Link to the "article" in the docs instead of just naming it Link to mentioned articles in the docs instead of just naming them Jan 2, 2024
@Mickeon Mickeon force-pushed the merge-this-before-2024-i-bet-you-wont branch from 06e86f5 to 78c9e2c Compare January 2, 2024 15:38
@Mickeon
Copy link
Contributor Author

Mickeon commented Jan 2, 2024

Removed the quotes around them

@akien-mga akien-mga merged commit dc95a3d into godotengine:master Jan 2, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@Mickeon Mickeon deleted the merge-this-before-2024-i-bet-you-wont branch January 2, 2024 17:08
@YuriSizov YuriSizov removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Jan 25, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.2.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@aaronfranke aaronfranke aaronfranke approved these changes

Assignees
No one assigned
Labels
documentation enhancement
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
5 participants
@Mickeon @akien-mga @YuriSizov @aaronfranke @dalexeev