Fix virtual keyboard for decimal values on Android #86619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
cherrypick:4.1
platform/android/java/lib/src/org/godotengine/godot/input/GodotEditText.java
Outdated
Show resolved
Hide resolved
platform/android/java/lib/src/org/godotengine/godot/input/GodotEditText.java
Outdated
Show resolved
Hide resolved
platform/android/java/lib/src/org/godotengine/godot/input/GodotEditText.java
Outdated
Show resolved
Hide resolved
Alex2782
force-pushed
the
fix_flag_decimal
branch
from
22f5686
to
07649fd
Compare
|
I could not find any information on how to activate However, it is possible to set up the Google keyboard. Gboard App - PlayStore
|
|
virtual keyboard for
|
m4gr3d
requested changes
Feb 13, 2024
platform/android/java/lib/src/org/godotengine/godot/input/GodotEditText.java
Outdated
Show resolved
Hide resolved
Alex2782
force-pushed
the
fix_flag_decimal
branch
2 times, most recently
from
38c41e7
to
b604e22
Compare
m4gr3d
requested changes
Feb 13, 2024
platform/android/java/lib/src/org/godotengine/godot/input/GodotEditText.java
Outdated
Show resolved
Hide resolved
platform/android/java/lib/src/org/godotengine/godot/input/GodotEditText.java
Outdated
Show resolved
Hide resolved
Alex2782
force-pushed
the
fix_flag_decimal
branch
from
b604e22
to
6f91c00
Compare
|
Thanks! |
|
Cherry-picked for 4.2.2. |
akien-mga
removed
cherrypick:4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #84091
In Europe,
comma (,)is usually used for decimal numbers and notperiod (.)Note: without
accept_characters / KeyListenerthe input is validated correctly, i.e.'-'is only possible at the beginning and'.'only once. TheKeyListeneris there to accept','. On a Samsung Android','is deactivated (I could not find a solution)Tests (numbertest.zip from #84091 (comment))
Pixel 4a (Android 13)
pixel_Screen_recording_20231229_231927.mp4
Samsung Tab S7 (Android 13)
samsung_Screen_recording_20231229_232305.mp4