Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MenuBar] Store and use global menu item indices. #86322

Merged
merged 1 commit into from
Feb 13, 2024
Merged

[MenuBar] Store and use global menu item indices. #86322

merged 1 commit into from
Feb 13, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Dec 19, 2023

  • Fixes error message on exit (on macOS).
  • Fixes updating main menu properties, when popup for special system menu is added in the middle of menu (and child node index is not global matching menu item index).

@bruvzg bruvzg added this to the 4.3 milestone Dec 19, 2023
@bruvzg bruvzg requested a review from a team as a code owner December 19, 2023 08:00
@akien-mga akien-mga merged commit f5cfc7f into godotengine:master Feb 13, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@clayjohn clayjohn mentioned this pull request Mar 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug platform:macos topic:gui
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@bruvzg @akien-mga