Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set an appropriate minimum size for labels in windows that display incorrectly #86145

Conversation

Rindbee
Copy link
Contributor

@Rindbee Rindbee commented Dec 14, 2023

When the label's autowrap_mode is AUTOWRAP_WORD_SMART and the initial text is set at the same time, it may have a higher height than expected. See #80218 (comment) for more details.

Set an appropriate minimum size for labels in windows that display incorrectly so that these windows display properly.

As a workaround for display issues in the editor caused by #77280.

Close #86136.
Closes #85551.

@Rindbee Rindbee requested a review from a team as a code owner December 14, 2023 03:18
@AThousandShips AThousandShips added bug topic:editor regression topic:export cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Dec 14, 2023
@AThousandShips AThousandShips added this to the 4.3 milestone Dec 14, 2023
YuriSizov
YuriSizov previously approved these changes Jan 12, 2024
Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above.

@Rindbee Rindbee force-pushed the set-a-suitable-size-for-labels-with-AUTOWRAP_WORD_SMART branch from e9bf368 to b778f65 Compare January 12, 2024 14:43
@Rindbee Rindbee changed the title Set an appropriate size for labels in windows that display incorrectly Set an appropriate minimum size for labels in windows that display incorrectly Jan 12, 2024
…correctly

When the label's `autowrap_mode` is `AUTOWRAP_WORD_SMART` and the initial `text`
is set at the same time, it may have a higher height.

Set an appropriate minimum size for labels in windows that display incorrectly
so that these controls display properly.
@Rindbee Rindbee force-pushed the set-a-suitable-size-for-labels-with-AUTOWRAP_WORD_SMART branch from b778f65 to f932c65 Compare January 12, 2024 15:08
@akien-mga akien-mga merged commit a2b94fe into godotengine:master Jan 15, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@Rindbee Rindbee deleted the set-a-suitable-size-for-labels-with-AUTOWRAP_WORD_SMART branch January 15, 2024 12:41
@YuriSizov YuriSizov removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Jan 25, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.2.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants