Stop using RTR() inside the "editor" folder
#86143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothyqiu
reviewed
Dec 14, 2023
YeldhamDev
force-pushed
the
ttr_here,_rtr_there
branch
4 times, most recently
from
0b655d2
to
ed39590
Compare
YeldhamDev
changed the title
RTR() for strings that only matter to the editorRTR() inside the "editor" folder
bruvzg
reviewed
Dec 15, 2023
YeldhamDev
force-pushed
the
ttr_here,_rtr_there
branch
from
ed39590
to
b525364
Compare
YeldhamDev
force-pushed
the
ttr_here,_rtr_there
branch
from
b525364
to
c7fb857
Compare
akien-mga
approved these changes
Mar 25, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RTR()is supposed to be only used in strings that are translatable in user projects, so strings that didn't follow this rule now useTTR()instead.This PR is necessary for my work to add built-in strings in the POT generation.Alright, unless we want to have loads of
#ifdefs, this is not a good idea. The PR has now been repurposed to just switch cases ofRTR()toTTR()inside the "editor" folder.