Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression when autocompleting subscript on get node #86111

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Fix regression when autocompleting subscript on get node #86111

merged 1 commit into from
Dec 13, 2023

Conversation

HolonProduction
Copy link
Member

@HolonProduction HolonProduction commented Dec 13, 2023 •
edited by akien-mga
Loading

Fixes #86108

Bugsquad edit:

@HolonProduction HolonProduction requested a review from a team as a code owner December 13, 2023 09:52
@AThousandShips
Copy link
Member

Please update the title to say what it fixes, rather than what caused the regression 🙂

@AThousandShips AThousandShips added bug topic:gdscript topic:editor regression cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Dec 13, 2023
@AThousandShips AThousandShips added this to the 4.3 milestone Dec 13, 2023
@HolonProduction HolonProduction changed the title Fix regression from #79386 Fix regression when autocompleting subscript on get node Dec 13, 2023
@akien-mga akien-mga merged commit aa5b6ed into godotengine:master Dec 13, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@HolonProduction HolonProduction mentioned this pull request Dec 18, 2023
Open
@Haydoggo Haydoggo mentioned this pull request Jan 9, 2024
Closed
@dalexeev dalexeev mentioned this pull request Jan 22, 2024
Closed
@YuriSizov YuriSizov removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Jan 25, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.2.2.

@HolonProduction HolonProduction deleted the get-node-fixup branch October 5, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug regression topic:editor topic:gdscript
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Drag & Drop intellisense with inferred type not working
4 participants
@HolonProduction @AThousandShips @akien-mga @YuriSizov