Fix squish DXT5 RA-As-RG channel swapping
#85967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
bug
topic:import
cherrypick:4.2
clayjohn
approved these changes
Dec 9, 2023
|
Thanks! |
YuriSizov
removed
the
cherrypick:4.2
|
Cherry-picked for 4.2.2. |
|
This PR caused a regression: #87770
|
|
Do you want to make a pr to revert? or a pr to fix. |
|
@fire I will wait for @BlueCube3310 and/or @clayjohn to respond. |
|
I think it makes sense to revert the cherrypick in 4.2. but then just fix the regression in master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #85863
Fixes DXT5 RA-As-RG images using incorrect color channels after decompression, as well as cleans up some of the code.
Results:
MRP for testing the changes:
SquishRA_As_RG.zip
Steps to reproduce:
new_standard_material_3d.tres