-
-
Notifications
You must be signed in to change notification settings - Fork 20.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Add 4.2-stable.expected file for GDExtension compatibility checks #85748
Merged
akien-mga
merged 1 commit into
godotengine:master
from
akien-mga:extension-check-add-4.2-expected-changes
Dec 7, 2023
+28
−15
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The text at this file should be changed to be in sync with the 4.0->4.1 file. I updated #76560 to include this. |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
This file contains the expected output of --validate-extension-api when run against the extension_api.json of the | ||
4.2-stable tag (the basename of this file). | ||
|
||
Only lines that start with "Validate extension JSON:" matter, everything else is considered a comment and ignored. They | ||
should instead be used to justify these changes and describe how users should work around these changes. | ||
|
||
Add new entries at the end of the file. | ||
|
||
## Changes between 4.2-stable and 4.3-stable |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes the issue that
singletons/EditorInterface
was missing in the API generated by--validation-extension-api
, thus failing the comparison with the file generated by--dump-extension-api
, which uses editor hint.The rest is just a cosmetic change to keep GDExtension stuff visually grouped together.