Copy track update mode when adding reset key #85540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
added
the
cherrypick:4.2
TokageItLab
approved these changes
Dec 30, 2023
|
InterpolationType and LoopWrap should be copied in the same way, since a warning is inevitable because of possible conflicts regarding interpolation for Radian. See also #86608. |
Should I do it in this PR? |
|
I think should be done if possible. If you don't do it, anyone just create a Follow up or PR later. |
akien-mga
approved these changes
Jan 2, 2024
|
Thanks! |
|
Cherry-picked for 4.2.2. |
akien-mga
removed
the
cherrypick:4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding a reset key (by right-clicking a key in animation track), the value is copied over to RESET animation, but not the update mode, and always created continuous track. After AnimationMixer changes this can result in a warning spam if the update mode does not match.
This PR ensures that when creating a reset key from an existing animation track, the track's update mode is copied to the RESET track (even if it already existed).