Fix documentation for icon_and_font_color editor setting
#85491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuriSizov
reviewed
Nov 29, 2023
YuriSizov
approved these changes
Nov 29, 2023
YuriSizov
added
the
cherrypick:4.2
|
removed the line number from the link and changed it to say "the set of rules defined in this file" |
|
Please squash your commits into one, see here |
BNTFryingPan
force-pushed
the
editor-icon-color-docs
branch
from
9f6e039
to
de59872
Compare
|
just wanted to make sure: this is all set, right? |
|
Yep! |
akien-mga
changed the title
icon_and_font_color editor settingicon_and_font_color editor setting
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
|
Cherry-picked for 4.2.1. |
akien-mga
removed
the
cherrypick:4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the documentation for the
interface/theme/icon_and_font_colorincorrectly states that the "dark" option makes the icons light, suitable for dark themes, and the "light" option makes the icons dark, suitable for light themes. this pr changes the documentation to say that the "dark" option makes the icons dark, suitable for light themes, and the "light" option makes the icons light, suitable for dark themes